Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate between Nextcloud file system and objects #144

Merged
merged 38 commits into from
Jan 27, 2025

Conversation

rjzondervan
Copy link
Contributor

No description provided.

rubenvdlinde and others added 29 commits January 15, 2025 21:38
- Introduced locking functionality in ObjectEntity with methods to lock, unlock, check lock status, and retrieve lock information.
- Enhanced ObjectService to include methods for locking and unlocking objects, along with appropriate exception handling for authorization and locking conflicts.
- Added new properties for locked state, owner, and authorization in ObjectEntity.
- Updated documentation for new methods and parameters.
- Added methods for locking and unlocking objects in ObjectEntityMapper, including user session checks and event dispatching for lock/unlock actions.
- Refactored ObjectService to utilize the new locking methods from ObjectEntityMapper, improving code organization and exception handling.
- Updated constructor of ObjectEntityMapper to inject dependencies for event dispatching and user session management.
- Ensured that the current user is set as the owner when creating or updating objects.
- Added documentation for new methods and parameters related to object locking.
- Introduced new API endpoints for locking, unlocking, and reverting objects in the ObjectsController.
- Enhanced ObjectEntityMapper and ObjectService to support reverting objects to previous states based on datetime, audit trail ID, or semantic version.
- Updated documentation to reflect new capabilities, including detailed descriptions of locking and version control features.
- Implemented error handling for locking and reverting operations, ensuring robust responses for various scenarios.
…ents

- Enhanced ObjectEntity to include 'locked' state and 'owner' properties.
- Updated mock data and tests to reflect new attributes for object locking and ownership.
- Introduced LockObject modal for locking functionality in the UI.
- Added methods in the object store for locking and unlocking objects, with appropriate error handling.
- Updated ObjectDetails and ObjectsList views to support locking and unlocking actions.
Also, read the folder property from an object if the property is set, instead of generating the whole thing over and over again.
Copy link
Member

@remko48 remko48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there are some breaking bugs

Also all the lint errors need to be fixed

src/modals/object/LockObject.vue Show resolved Hide resolved
src/views/object/ObjectDetails.vue Show resolved Hide resolved
src/modals/object/LockObject.vue Outdated Show resolved Hide resolved
Copy link
Member

@remko48 remko48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of time I will approve this PR.

Please Note! That the issue in this comment is not yet resloved!

@remko48 remko48 merged commit 4750764 into development Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants