Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): updating main version to prod and migration fix #4330

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

kkast
Copy link
Contributor

@kkast kkast commented Nov 17, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 14 4h 20m 18
RustNinja 10 4h 35m 14
mina86 6 1d 1h 41m 23
kkast 6 30m 0
0xBrainjar2 3 12h 57m 12
JafarAz 3 15h 5m 1
vmarkushin 2 2h 24m 5
blasrodri 2 6d 3h 6m 0
bengalmozzi 1 23h 12m 0

Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4330/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4330/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4330/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4330/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4330/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@RustNinja RustNinja self-requested a review November 17, 2023 18:24
RustNinja
RustNinja previously approved these changes Nov 17, 2023
RustNinja
RustNinja previously approved these changes Nov 20, 2023
@dzmitry-lahoda
Copy link
Contributor

023-11-20T13:35:29.0594557Z composable-build>   48:                0x0 - <unknown>
2023-11-20T13:35:29.0595690Z composable-build> failures:
2023-11-20T13:35:29.0597220Z composable-build>     test::dual_asset_constant_product_tests::exchange_failure
2023-11-20T13:35:29.0599699Z composable-build> test result: FAILED. 30 passed; 1 failed; 7 ignored; 0 measured; 0 filtered out; finished in 0.20s
2023-11-20T13:35:29.0601978Z composable-build> error: test failed, to rerun pass `-p pallet-pablo --lib`
2023-11-20T13:35:30.6291963Z error: builder for '/nix/store/03qi4bd55j9nw8ppqdnzkhhavy6crpcw-composable-build-8.10040.3.drv' failed with exit code 101;
2023-11-20T13:35:30.6293997Z        last 10 log lines:
2023-11-20T13:35:30.6295053Z        >   47:     0x7ffff7de455c - __GI___clone3
2023-11-20T13:35:30.6296176Z        >   48:                0x0 - <unknown>
2023-11-20T13:35:30.6297071Z        >
2023-11-20T13:35:30.6297638Z        >
2023-11-20T13:35:30.6298216Z        > failures:
2023-11-20T13:35:30.6299196Z        >     test::dual_asset_constant_product_tests::exchange_failure
2023-11-20T13:35:30.6300277Z        >
2023-11-20T13:35:30.6301577Z        > test result: FAILED. 30 passed; 1 failed; 7 ignored; 0 measured; 0 filtered out; finished in 0.20s
2023-11-20T13:35:30.6303093Z        >
2023-11-20T13:35:30.6304122Z        > error: test failed, to rerun pass `-p pallet-pablo --lib`
2023-11-20T13:35:30.6306360Z        For full logs, run 'nix log /nix/store/03qi4bd55j9nw8ppqdnzkhhavy6crpcw-composable-build-8.10040.3.drv'.
2023-11-20T13:35:30.6733880Z error: 1 dependencies of derivation '/nix/store/0xvaybrbk42dyajnhqdnl3gl6lpc2lw3-all-rust-qa-packages.drv' failed to build
2023-11-20T13:35:30.7555156Z Stopped watching /nix/store and waiting for queue to empty ...
2023-11-20T13:35:30.7556585Z Waiting to finish: 4 pushing, 0 in queue

pablo failed?

how.. may be it is property test?

@kkast kkast merged commit 97124d5 into main Nov 21, 2023
@kkast kkast deleted the kkast/update_main branch November 21, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants