DRY Email Template

[rathorevaibhav]

Description

The following is an email template that gets sent when a reviewer rejects an article. Can you refactor the code and remove duplication?

const ReviewRejectEmailTemplate = ({
  articleTitle,
  authorName,
  reviewerName,
  receiverName,
  shortId,
}) => {
  const result = {
    cc: '',
    subject: 'Kotahi Notification Email',
    content: '',
  }

  switch (process.env.INSTANCE_NAME) {
    case 'aperture':
      result.cc = 'apertureadmin@aperture.domain.org'
      result.subject = 'Reviewer has rejected review invitation'
      result.content = `<p>
      <p>Dear ${receiverName},</p>
      <p>Reviewer ${reviewerName} has rejected your review invitation. Please log into the publishing platform and invite another reviewer to the submission:</p>
      <p>“${shortId}; ${articleTitle}, ${authorName}”</p>
      <p>Thank you,</p>
      <p>Aperture Neuro Team</p>
    </p>`
      break
    default:
      result.subject = 'Reviewer has rejected review invitation'
      result.content = `<p>
      <p>Dear ${receiverName},</p>
      <p>Reviewer ${reviewerName} has rejected your review invitation. Please log into the publishing platform and invite another reviewer to the submission:</p>
      <p>“${shortId}; ${articleTitle}, ${authorName}”</p>
      <p>Thank you,</p>
      <p>Kotahi Dev</p>
    </p>`
  }

  result.content = result.content.replace(/\n/g, '')

  return result
}

module.exports = ReviewRejectEmailTemplate

[belwalshubham]

@rathorevaibhav so here we can remove the switch statement and get the instance name from env. and email template used according to the instance name and If no matching instance is found, the default instance is used.

const ReviewRejectEmailTemplate = ({
  articleTitle,
  authorName,
  reviewerName,
  receiverName,
  shortId,
}) => {
  const instances = {
    aperture: {
      cc: 'apertureadmin@aperture.domain.org',
      sender: 'Aperture Neuro Team',
    },
    default: {
      cc: '',
      sender: 'Kotahi Dev',
    },
  };

  const instanceName = process.env.INSTANCE_NAME || 'default';
  const instance = instances[instanceName];

  const result = {
    cc: instance.cc,
    subject: 'Reviewer has rejected review invitation',
    content: `<p>
      <p>Dear ${receiverName},</p>
      <p>Reviewer ${reviewerName} has rejected your review invitation. Please log into the publishing platform and invite another reviewer to the submission:</p>
      <p>“${shortId}; ${articleTitle}, ${authorName}”</p>
      <p>Thank you,</p>
      <p>${instance.sender}</p>
    </p>`,
  };

  result.content = result.content.replace(/\n/g, '');

  return result;
};

module.exports = ReviewRejectEmailTemplate;