Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality of Life additions #457

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Quality of Life additions #457

wants to merge 2 commits into from

Conversation

maplesyruppppppp
Copy link
Contributor

@maplesyruppppppp maplesyruppppppp commented Nov 26, 2024 •
edited
Loading

WIP pull request of stuff that gives the game more quality in a way

todo list:

  • lil' glow effect of windows in the philly stage

image

  • [WIP] snow shader/emitter in mall stages
  • vignette in monster song that increases as you lose health and decreases as you gain health, also disappears when a thunder strike occurs, fades back in when its done (as what nex has suggested to me)
2024-11-26_15-26-18.mp4

suggestions, ideas and criticism are open :]

@THEkatinamicrowave
Copy link
Contributor

THEkatinamicrowave commented Dec 5, 2024 •
edited
Loading

kill santa at the end of eggnog
also he should stay there during horrorland too
not because it's canon but because it would make me laugh
also santa only appears if you killed him in eggnog
so basically only in story mode
or if you played eggnog in freeplay and then wh

@NexIsDumb
Copy link
Member

kill santa at the end of eggnog
also he should stay there during horrorland too
not because it's canon but because it would make me laugh
also santa only appears if you killed him in eggnog
so basically only in story mode
or if you played eggnog in freeplay and then wh

nope, that should be in the vslice modpack instead im making for cne

@THEkatinamicrowave
Copy link
Contributor

kill santa at the end of eggnog
also he should stay there during horrorland too
not because it's canon but because it would make me laugh
also santa only appears if you killed him in eggnog
so basically only in story mode
or if you played eggnog in freeplay and then wh

nope, that should be in the vslice modpack instead im making for cne

ok 😔

NeeEoo
NeeEoo reviewed Jan 10, 2025
View reviewed changes
assets/data/stages/philly.xml
@@ -3,6 +3,9 @@
<sprite name="bg" x="-100" y="0" sprite="sky" scroll="0.1" zoomfactor="0"/>
<sprite name="city" x="-10" y="0" sprite="city" scroll="0.3" scale="0.85" updateHitbox="true" zoomfactor="0.3"/>
<sprite name="light" x="-10" y="0" sprite="win" scroll="0.3" scale="0.85" updateHitbox="true" zoomfactor="0.3"/>
<sprite name="lightGlow" x="-10" y="0" sprite="winGlow" scroll="0.3" scale="0.85" updateHitbox="true" zoomfactor="0.3">
<property name="blend" type="float" value="1"/>
Copy link
Member

@NeeEoo NeeEoo Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a int not float

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeeEoo NeeEoo NeeEoo left review comments

@THEkatinamicrowave THEkatinamicrowave THEkatinamicrowave left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maplesyruppppppp @THEkatinamicrowave @NexIsDumb @NeeEoo