From 13e0e0e1a84c41ff23bf69b771c1262ef2e7c125 Mon Sep 17 00:00:00 2001 From: Sergey Zhukov Date: Fri, 14 Jun 2024 01:32:11 +0400 Subject: [PATCH] fix: socket timeout is in seconds, not in ms --- src/smartinspect/protocols/tcp_protocol.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/smartinspect/protocols/tcp_protocol.py b/src/smartinspect/protocols/tcp_protocol.py index aa6e4e2..749a672 100644 --- a/src/smartinspect/protocols/tcp_protocol.py +++ b/src/smartinspect/protocols/tcp_protocol.py @@ -143,7 +143,10 @@ def _internal_connect(self): def _internal_initialize_socket(self) -> socket.socket: socket_ = socket.socket(socket.AF_INET, socket.SOCK_STREAM) socket_.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) - socket_.settimeout(self._timeout) + # settimeout argument is in seconds, smartinspect timeout option is milliseconds + # convert ms to s by dividing by 1000 + # https://docs.python.org/3/library/socket.html#socket.socket.settimeout + socket_.settimeout(self._timeout / 1000) socket_.connect((self._hostname, self._port)) return socket_