Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add python-tasks to examples pixi environment" #304

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert "add python-tasks to examples pixi environment" #304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e804bf1
Revert "add `python-tasks` to `examples` pixi environment (#6991)"
jleibs Jul 26, 2024
e90304d
Clean up pixi comments
jleibs Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions pixi.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,8 @@ wheel-test = [

# These environments use the dev version of the python package.
# The package will be installed in editable mode, so changes to the python code will be reflected immediately.
# However, any changes to do the rust bindings will require running `pixi run -e examples py-build`.
examples = [
"examples-common",
"python-dev",
"wheel-build",
"python-tasks",
"examples-tasks",
]
# However, any changes to do the rust bindings will require running `pixi run py-build-examples`.
examples = ["examples-common", "python-dev", "wheel-build", "examples-tasks"]
examples-ocr = ["examples-ocr", "wheel-build"]

# This environment uses the pypi-published version of the python package. This avoids the need to
Expand Down Expand Up @@ -277,8 +271,15 @@ py-build-common = { cmd = "PIP_REQUIRE_VIRTUALENV=0 RERUN_ALLOW_MISSING_BIN=1 ma
"rerun-build", # We need to build rerun-cli since it is bundled in the python package.
] }

# Build the `rerun-notebook` package.
py-build-notebook = { cmd = "pip install -e rerun_notebook", depends_on = [
"js-build-base",
] }


[feature.python-tasks.tasks]

# Dedicated alias for building the python bindings for the `py` environment.
py-build = "pixi run -e py py-build-common"

# Helper alias to run the python interpreter in the context of the python environment
Expand All @@ -292,10 +293,6 @@ py-plot-dashboard = { cmd = "python tests/python/plot_dashboard_stress/main.py",
"py-build",
] }

# Build the `rerun-notebook` package.
py-build-notebook = { cmd = "pip install -e rerun_notebook", depends_on = [
"js-build-base",
] }

# Run the Python tests.
# Don't call this on CI - use `nox` to run tests on all supported Python versions instead.
Expand All @@ -310,6 +307,8 @@ py-test = { cmd = "python -m pytest -vv rerun_py/tests/unit", depends_on = [
rerun-from-path = "rerun"

[feature.examples-tasks.tasks]

# Dedicated alias for building the python bindings for the `examples` environment.
py-build-examples = "pixi run -e examples py-build-common"

# Python example utilities
Expand Down
Loading