Remove unnecessary test dependencies on RSA-512 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_unsupported_hash and test_prehashed_digest_mismatch work just fine with realistic RSA key sizes. (They also, as written, silently test nothing when the backend rejects RSA-512. As a reminder, RSA-512 was broken since 1999.) test_rsa_fips_small_key wants a small key, but I assume RSA-1024 is fine.
CodSpeed Performance ReportMerging #181 will not alter performanceComparing Summary
|
coco-speed
force-pushed
the
main
branch
20 times, most recently
from
a0548c1 to
3e9fc8b
Compare
coco-speed
force-pushed
the
main
branch
7 times, most recently
from
04d90df to
30167eb
Compare
coco-speed
force-pushed
the
main
branch
27 times, most recently
from
94b8b3a to
35a0d9c
Compare
coco-speed
force-pushed
the
main
branch
3 times, most recently
from
619c8f2 to
ce42b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically by CodSpeed to track performance changes of the pull request pyca/cryptography#11444.
The original branch is fork-11444-davidben/test-rsa-512-2