Don't include engine.h when OPENSSL_NO_ENGINE is defined #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #124 will not alter performanceComparing Summary
|
art049
force-pushed
the
fork-11328-tiran/engine-include
branch
from
656defc to
85f2ae2
Compare
Fedora 41 and RHEL 10 are deprecating and phasing out OpenSSL ENGINE support. Downstream has moved `openssl/engine.h` into a separate RPM package and is recompiling packages with `-DOPENSSL_NO_ENGINE=1`. The compiler flag disables PyCA cryptography's ENGINE support successfully. We also like to build the downstream package without the `engine.h` header file present. This commit makes the include conditional. The `ENGINE` type is defined in `openssl/types.h`. See: https://src.fedoraproject.org/rpms/openssl/c/e67e9d9c40cd2cb9547e539c658e2b63f2736762?branch=rawhide See: https://issues.redhat.com/browse/RHEL-33747 Signed-off-by: Christian Heimes <christian@python.org>
art049
force-pushed
the
fork-11328-tiran/engine-include
branch
from
85f2ae2 to
7a1927b
Compare
art049
force-pushed
the
main
branch
7 times, most recently
from
9e8ae8f to
8f15758
Compare
coco-speed
force-pushed
the
main
branch
19 times, most recently
from
a1fb772 to
a961beb
Compare
coco-speed
force-pushed
the
main
branch
27 times, most recently
from
94b8b3a to
35a0d9c
Compare
coco-speed
force-pushed
the
main
branch
3 times, most recently
from
619c8f2 to
ce42b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically by CodSpeed to track performance changes of the pull request pyca/cryptography#11328.
The original branch is fork-11328-tiran/engine-include