Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepencies between coir and mteb #14

Open
bclavie opened this issue Jan 23, 2025 · 1 comment
Open

Discrepencies between coir and mteb #14

bclavie opened this issue Jan 23, 2025 · 1 comment

Comments

@bclavie
Copy link

bclavie commented Jan 23, 2025

This is a crosspost for visibility of the issue I just opened on mteb: embeddings-benchmark/mteb#1861


Hi there!

When reviewing the new gte-modernbert-base model, I noticed I struggled to reproduce their CoIR results with the coir library. After a bit of digging and a pointer from the authors, it appears that the mteb library matches their results, but that those are wildly different from what coir reports!

Recently, there's also been some discussions about code retrieval mismatched results about the new SFR model vs Voyager (here), and while I haven't yet had time to test it out, the magnitude of the discrepancies appear to be fairly similar to what I'm seeing, so this could be the issue.

Even more puzzling, in trying to figure out which one was correct, I whipped up an extremely simple ST + ranx notebook and it gave me results that... matched neither library 😭 although it was way closer to mteb than to coir. This was put together very quickly late at night, so there might be one silly mistake somewhere in there causing the issues.

I've put together a repository to reproduce the exact issue with minimal scripts, using exactly the code I ran.

Direct links:

Let me know if I can do anything else to help diagnose this!

@bclavie
Copy link
Author

bclavie commented Jan 23, 2025

As per the discussions in the MTEB repo embeddings-benchmark/mteb#1861 (comment), it seems the issue is because the default behaviour of YourCustomDEModel involves silently adding prefixes to queries & documents.

@archersama perhaps it would be worthwhile to not have this as the default behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant