Tan 3667/useformatcurrency hook #10177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brentguf
force-pushed
the
TAN-3667/useformatcurrency-hook
branch
from
1af52ff to
18126af
Compare
Closed
brentguf
commented
Jan 24, 2025
Comment on lines
+16
to
+26
| if (currency === 'TOK') { | ||
| return (amount: number) => | ||
| formatMessage(messages.xTokens, { numberOfTokens: formatNumber(amount) }); | ||
| } | ||
|
|
||
| if (currency === 'CRE') { | ||
| return (amount: number) => | ||
| formatMessage(messages.xCredits, { | ||
| numberOfCredits: formatNumber(amount), | ||
| }); | ||
| } |
There was a problem hiding this comment.
This ~mimics behavior from FormattedBudget.
EdwinKato
approved these changes
Jan 28, 2025
Tan 3664/formattedbudget
…into TAN-3667/useformatcurrency-hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
formatCurrency, obtained from callinguseFormatCurrency, will be used in all places where we're formatting currencies in future PRs. An example: #10150.First I created just the
formatCurrencyfunction, but it was cumbersome to providelocaleandappConfigurationon each use, hence the hook.Changelog
Technical
formatCurrencyanduseFormatCurrencyhook.