Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(library): Set library.keywords as empty array (M2-6857) #1396

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

iwankrshkin
Copy link
Contributor

… null

  • Tests for the changes have been added
  • Related documentation has been added / updated
  • OSS packages added to MindLogger open source credit page

πŸ“ Description

πŸ”— Jira Ticket M2-6857

Changes include:

  • Library kwargs is not null anymore

πŸͺ€ Peer Testing

✏️ Notes

Copy link

github-actions bot commented Jun 10, 2024

➑️ Preview environment failed to be destroyed

Copy link

❌ E2E tests failed

# Conflicts:
#	src/apps/shared/commands/patch_commands.py
@iwankrshkin iwankrshkin changed the title fix(library): Set library.keywords and library.search_keywords as not null (M2-6857) fix(library): Set library.keywords as [ ] (M2-6857) Jun 13, 2024
@vshvechko vshvechko changed the title fix(library): Set library.keywords as [ ] (M2-6857) fix(library): Set library.keywords as empty array (M2-6857) Jun 13, 2024
@iwankrshkin iwankrshkin requested a review from vshvechko June 13, 2024 13:07
src/apps/library/domain.py Outdated Show resolved Hide resolved
src/apps/library/domain.py Outdated Show resolved Hide resolved
src/apps/library/domain.py Outdated Show resolved Hide resolved
@iwankrshkin iwankrshkin merged commit 1133a5c into develop Jun 14, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants