fix: update minDate conditional logic (M2-8317, M2-8275, M2-8032) #2023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix
minDate
condition when selectingBETWEEN_DATES
orOUTSIDE_OF_DATES
conditional logic by using the correct value and addressing a date parsing issue.🔗 Jira Ticket M2-8317
🔗 Jira Ticket M2-8275
🔗 Jira Ticket M2-8032
Changes include:
minDateValue
instead ofminValue
when setting upDatePicker
minDate
greater thanmaxDate
📸 Screenshots
Case 1 (M2-8317):
Before: It's not possible to select a date prior to "today" in the second DatePicker when selecting Outside/Between conditional logic
CleanShot.2025-01-29.at.17.02.02.mp4
After: It's now possible to select a date prior to "today" but greater than the first date when selecting Outside/Between conditional logic
CleanShot.2025-01-29.at.17.02.50.mp4
Case 2 (M2-8275):
Date parsing error after saving
Before:
CleanShot.2025-01-29.at.16.56.05.mp4
After:
CleanShot.2025-01-29.at.17.08.54.mp4
🪤 Peer Testing
✏️ Notes
The
enableItemFlowItemsG2
andenableItemFlowExtendedItems
feature flags need to be enabled in order to test Date conditional logic.Web app conditional logic for Date/Time is currently not working as expected, will be addressed by M2 8302Web app conditional logic can be tested with this PR/Amplify environment fix: Update Time/TimeRange/Date validations (M2-8302) mindlogger-web-refactor#573