Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize cmake and update debug options #474

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Feb 5, 2025

Use add_compile_options and add_link_options to modernize and simplify cmake rules

Also use -0g for debug mode compiling per Arvid recommendations as this allows for optimizations that don't impact debugging

@emlowe emlowe requested review from AmineKhaldi and arvidn February 5, 2025 18:07
Copy link

coveralls-official bot commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13167823220

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 54 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.7%) to 79.701%

Files with Coverage Reduction New Missed Lines %
src/encoding.hpp 1 94.83%
lib/include/picosha2.hpp 1 93.5%
src/util.hpp 2 92.48%
src/disk.hpp 2 83.85%
src/b17sort_manager.hpp 3 0.0%
src/phase1.hpp 3 94.15%
src/b17phase4.hpp 3 0.0%
src/prover_disk.hpp 5 87.08%
src/plotter_disk.hpp 7 71.17%
src/b17phase3.hpp 12 0.0%
Totals Coverage Status
Change from base Build 13081686849: 0.7%
Covered Lines: 3573
Relevant Lines: 4483

💛 - Coveralls

hoffmang9
hoffmang9 previously approved these changes Feb 5, 2025
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@AmineKhaldi AmineKhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sent some suggestions.

Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
Copy link
Contributor

@AmineKhaldi AmineKhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not seeing these suggestions earlier (the nesting).

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lebtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants