-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize cmake and update debug options #474
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 13167823220Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Sent some suggestions.
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not seeing these suggestions earlier (the nesting).
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lebtm
Use
add_compile_options
andadd_link_options
to modernize and simplify cmake rulesAlso use
-0g
for debug mode compiling per Arvid recommendations as this allows for optimizations that don't impact debugging