Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python 3.8 #471

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Remove python 3.8 #471

merged 4 commits into from
Jan 31, 2025

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jan 31, 2025 •
edited
Loading

Remove 3.8 for all workflows and matrices

Also use Ubuntu-22 for coverage task to avoid some as yet undiagnosed issue with lcov on ubuntu-latest which is now ubuntu-24

hoffmang9
hoffmang9 previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it!

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 13080672048

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.051%
Totals Coverage Status
Change from base Build 12583901910: 0.02%
Covered Lines: 3498
Relevant Lines: 4425
💛 - Coveralls

@emlowe emlowe requested review from hoffmang9 January 31, 2025 21:05
hoffmang9
hoffmang9 reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming CI finishes well

hoffmang9
hoffmang9 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying a wider approval?

@emlowe emlowe merged commit 199ed46 into main Jan 31, 2025
55 checks passed
@emlowe emlowe deleted the EL.remove-3.8 branch January 31, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

@cmmarslender cmmarslender Awaiting requested review from cmmarslender

@altendky altendky Awaiting requested review from altendky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emlowe @hoffmang9