Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): add new QueryID pattern #7313

Merged
merged 17 commits into from
Jan 20, 2025
Merged

feat(engine): add new QueryID pattern #7313

merged 17 commits into from
Jan 20, 2025

Conversation

cx-ruiaraujo
Copy link
Contributor

@cx-ruiaraujo cx-ruiaraujo commented Jan 16, 2025 •
edited
Loading

Reason for Proposed Changes

  • CxOne Platform generates custom KICS queries with the following ID pattern <prefix>:<uint64>
  • This is not supported by KICS when using the flag -i, --include-queries

Proposed Changes

  • Add support for new QueryID pattern

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added feature New feature query New query feature labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.1.3

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-ruiaraujo cx-ruiaraujo changed the title feat(engine): add cxone queryid validation for custom queries feat(engine): add new QueryID pattern Jan 17, 2025
@cx-ruiaraujo cx-ruiaraujo self-assigned this Jan 17, 2025
@cx-ruiaraujo cx-ruiaraujo marked this pull request as ready for review January 17, 2025 14:53
@cx-ruiaraujo cx-ruiaraujo requested a review from a team as a code owner January 17, 2025 14:53
ArturRibeiro-CX
ArturRibeiro-CX requested changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read my comment please 💪.
Thanks!

test/fixtures/new_queryid_validation/metadata.json Outdated Show resolved Hide resolved
ArturRibeiro-CX
ArturRibeiro-CX approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes 😃

cxMiguelSilva
cxMiguelSilva approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-ruiaraujo cx-ruiaraujo merged commit 1bdf6e7 into master Jan 20, 2025
26 checks passed
@cx-ruiaraujo cx-ruiaraujo deleted the ruiar-add-new-queryid-validation branch January 20, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@ArturRibeiro-CX ArturRibeiro-CX ArturRibeiro-CX approved these changes

Assignees

@cx-ruiaraujo cx-ruiaraujo

Labels
feature New feature query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cx-ruiaraujo @cxMiguelSilva @ArturRibeiro-CX