Skip to content

Commit

Permalink
infra: remove duplicate lint and run tests (#67)
Browse files Browse the repository at this point in the history
I noticed in `pr-validation` we are running our linter twice, and not
running unit-tests at all.
  • Loading branch information
Baruch Odem (Rothkoff) authored May 12, 2023
1 parent 0a85890 commit 842cec6
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions .github/workflows/pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@ on:
- master

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- uses: actions/setup-go@v4
with:
go-version: '^1.20'

- name: Go Linter
run: docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.52.0 golangci-lint run -v -E gofmt --timeout=5m

test:
strategy:
matrix:
Expand All @@ -38,6 +24,9 @@ jobs:
- name: Go Linter
run: docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.52.0 golangci-lint run -v -E gofmt --timeout=5m

- name: Go Test
run: go test -v ./...

build:
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit 842cec6

Please sign in to comment.