Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ignoring missing keys #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fedorov
Copy link

@fedorov fedorov commented Oct 15, 2016

This exposes already available flag from _are_same in the top-level call.

fedorov added a commit to fedorov/dcmqi that referenced this pull request Oct 16, 2016
This one is from https://github.com/ChannelIQ/jsoncompare with minor
modification submitted in this PR ChannelIQ/jsoncompare#8.

Without the modification, it is required that the compared JSONs have identical
number of keys, which is not logical, since we are specifically interested in
ignoring specified keys.

Related to QIICR#97
che85 pushed a commit to che85/dcmqi that referenced this pull request Oct 19, 2016
This one is from https://github.com/ChannelIQ/jsoncompare with minor
modification submitted in this PR ChannelIQ/jsoncompare#8.

Without the modification, it is required that the compared JSONs have identical
number of keys, which is not logical, since we are specifically interested in
ignoring specified keys.

Related to QIICR#97
che85 pushed a commit to che85/dcmqi that referenced this pull request Oct 20, 2016
This one is from https://github.com/ChannelIQ/jsoncompare with minor
modification submitted in this PR ChannelIQ/jsoncompare#8.

Without the modification, it is required that the compared JSONs have identical
number of keys, which is not logical, since we are specifically interested in
ignoring specified keys.

Related to QIICR#97
che85 added a commit to che85/dcmqi that referenced this pull request Oct 20, 2016
- added missing attributes
- fixed json comparison script (for the reference ChannelIQ/jsoncompare#8 and ChannelIQ/jsoncompare#9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant