Fix slug generation #207
Merged
Fix slug generation #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slugs are intended to be human-readable and unique for an artifact. However when a user submitted multiple versions they often got duplicated slugs. This was because our check for an existing version was based on the artifacts date, not the version date. We attempted to fix in #133, but the issue persisted. I just happened to notice this filter code seemed wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slugs are intended to be human-readable and unique for an artifact. However when a user submitted multiple versions they often got duplicated slugs. This was because our check for an existing version was based on the artifacts date, not the version date.
We attempted to fix in #133, but the issue persisted. I just happened to notice this filter code seemed wrong.
This also fixes test runner to always use sqlite3.