Cd/eng 1804/prompt reconciliation for vercel ai sdk #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
constantinidan
commented
Aug 24, 2024
constantinidan
commented
Fix Vercel AI SDK. On the picture, you can now see the correct prompt matching.
Dam-Buty
reviewed
Aug 26, 2024
Comment on lines
+104
to
+106
| if (typeof (message as any).literalMetadata === 'function') { | ||
| return (message as any).literalMetadata(); | ||
| } |
There was a problem hiding this comment.
slightly cleaner style IMO
Suggested change
| if (typeof (message as any).literalMetadata === 'function') { | |
| return (message as any).literalMetadata(); | |
| } | |
| const metadata = (message as any).literalMetadata(); | |
| if (typeof metadata === 'function') { | |
| return metadata(); | |
| } |
There was a problem hiding this comment.
the suggestion does not work if the messages are not linked to a prompt. .literalMetadata() does not exist.
desaxce
approved these changes
Aug 28, 2024
desaxce
deleted the
cd/ENG-1804/prompt-reconciliation-for-vercel-ai-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.