Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not all versions of open ai work #26

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: Not all versions of open ai work #26

merged 1 commit into from
Jun 6, 2024

Conversation

Granipouss
Copy link

Otherwise there was typing errors.

@clementsirieix clementsirieix self-requested a review June 4, 2024 10:58
clementsirieix
clementsirieix reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@clementsirieix clementsirieix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the update break the e2e tests?

@Granipouss
Copy link
Author

Do the update break the e2e tests?

Nope, I think it's because something changed on staging

@Granipouss Granipouss requested a review from clementsirieix June 6, 2024 06:03
clementsirieix
clementsirieix approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@clementsirieix clementsirieix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Granipouss Granipouss merged commit 7790ab0 into main Jun 6, 2024
2 checks passed
@Granipouss Granipouss deleted the brendan/fix-openaitypes branch June 6, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clementsirieix clementsirieix clementsirieix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Granipouss @clementsirieix