feat: add getSteps API #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Granipouss
reviewed
May 13, 2024
| { | ||
| field: 'tags', | ||
| operator: 'in', | ||
| value: ['to_score'] |
There was a problem hiding this comment.
Isn't testing without any 'ids' in the query, risky ?
As in, there can be an existing step with that tag from any other test run, and that would make that test fail.
There was a problem hiding this comment.
Yes, I will add a filter on the id here!
willydouhard
approved these changes
May 13, 2024
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Granipouss)
Granipouss
approved these changes
May 13, 2024
desaxce
deleted the
hugues/eng-1337-add-get_steps-on-sdks-with-filters-on-tags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
getStepsAPITo test:
tagsgetStepsto get the step which has the specified tagsStepobjectThis change is