-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup a basic vercel sdk instrumentation #19
Conversation
934c1f7
to
845c8de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vercel sdk is adding a lot of dependencies, have we checked the size of the build?
Reviewed 4 of 6 files at r1, all commit messages.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @Granipouss and @willydouhard)
src/instrumentation/vercel-sdk.ts
line 64 at r1 (raw file):
delete settings.prompt; delete settings.abortSignal; return settings;
Won't it work to simply use omit(settings, ["model", "prompt", "abortSignal"])
?
Also in that case we probably do not need this method for that purpose.
src/instrumentation/vercel-sdk.ts
line 123 at r1 (raw file):
ttFirstToken = Date.now() - startTime; } outputTokenCount += 1;
Question: I thought a chunk is not strictly equal to a single token?
The dependencies are added as peerDeps and devDeps so it shouldn't impact the final build |
Previously, clementsirieix (Clément Sirieix) wrote…
Like lodash |
Previously, clementsirieix (Clément Sirieix) wrote…
No idea, I just took the logic from the openAI instrument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Granipouss)
See tests for usage examples.
For now it just create generations with metrics, inputs and outputs.
TODO (maybe not all now)
generateText
orstreamText
This change is