Skip to content

feat: Add perf benchmark tests (with breaking changes due to ESM updates) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaybhanushali3166
Copy link

This PR closes #40. However, as part of the changes, I updated some dependencies and module handling, which has caused issues with the linting and test setup.

  1. Linting Issue: The .eslintrc.js configuration is outdated, and it's not compatible with ESM-based module execution. The recommended setup for modern ESlint is to migrate to eslint.config.js. I’ve found a migration guide here, however this tool works great for static config and will need careful implementation for dynamic config.
  2. Test Issue: The Mocha test setup is using a CommonJS approach, which might require an upgrade to support ESM modules fully. This has led to test failures.

I'd appreciate guidance on how best to resolve these issues, particularly regarding ESM module support and Mocha compatibility.

@CLAassistant
Copy link

CLAassistant commented May 1, 2025

CLA assistant check
All committers have signed the CLA.

@wemeetagain
Copy link
Member

Thanks for the PR, several comments:

  • ESM - we definitely want to do this, it may be prudent to do this as a separate PR and cut a breaking release
  • linting - we're now using biome, check out how we're doing it in the lodestar repo
  • testing - we're now using vitest, check out how we're doing it in the lodestar repo
  • benchmarking - we're now using @chainsafe/benchmark (check out how we're doing it in the lodestar repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add perf tests to benchmark changes
3 participants