Trajopt Profiling #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for shooting methods
…th static goal and cost matrices
…ta in case we need it later
alberthli
commented
Dec 5, 2023
| "torch>=1.13.1", | ||
| "tensorboard>=2.15.1", | ||
| # "torch>=1.13.1", | ||
| "tensorboard>=2.13.0", # [Dec. 4, 2023] https://github.com/tensorflow/tensorflow/issues/62075#issuecomment-1808652131 |
There was a problem hiding this comment.
[NOTE] As it turns out, if I pin the version to 2.13.0, the code check workflow fails. However, we know that things are broken with the most recent tensorflow version, so we should probably not merge this yet.
alberthli
commented
Dec 5, 2023
Comment on lines
+50
to
+51
| "tensorflow>=2.13.0", # [Dec. 4, 2023] https://github.com/tensorflow/tensorflow/issues/62075#issuecomment-1808652131 | ||
| "tensorboard-plugin-profile>=2.13.0", |
There was a problem hiding this comment.
See above comment about pinning versions.
pculbertson
approved these changes
Dec 5, 2023
| fn1() | ||
|
|
||
| # stuff we do want to specifically profile | ||
| with jax.named_scope("name_of_your_choice"): |
There was a problem hiding this comment.
Quick q: I know TraceAnnotation didn't work here but it's maybe good to note this here since the jax profiling tool recommends it
| ``` | ||
| tensorboard --logdir=/dir/to/profiling/results --port <port> | ||
| ``` | ||
| where `--port` should be some open port like `8008`. In the top right dropdown menu which should say "Inactive," scroll down and select "Profile." Select the run you'd like to analyze and under tools, the most useful tab will usually be "trace_viewer." |
There was a problem hiding this comment.
You might consider adding some screenshots for folks who are unfamiliar with flame charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips on profiling
tensorboard-related dependencies topyproject.tomlProfiling results:
Takeaways from the above results:
stepis simply to use fewer solver iterations and line search iterations._positionsubroutine of the forward dynamics takes about 26% of the total runtime!_accelerationsubroutine takes about 11% of the total runtimeEssentially 100% of the runtime of
forwardis captured by the above operations, which should give some insight into code optimization prioritizes on themjxside if we want to give some feedback. We should remember that the contact engine is DISABLED for this benchmark.