Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AA008: Determine Pass-by-Value Impact of willScanNewCells() #33

Open
Heckart opened this issue Mar 13, 2025 · 0 comments
Open

AA008: Determine Pass-by-Value Impact of willScanNewCells() #33

Heckart opened this issue Mar 13, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@Heckart
Copy link
Collaborator

Heckart commented Mar 13, 2025

Assigned Dev: N/A

Description: willScanNewCells() passes an Aircraft by value rather than by reference in order to use the Aircraft's scan() function to determine if new Cells will be scanned. This could be a cause of the searching performance on large GridMaps. A 100x100 Grid means the Aircraft takes >240KB of memory, which is created each time willScanNewCells() is called in findRoute() (which is three times per loop). Modifying willScanNewCells() to allow passing by reference could possible improve performance.
Priority: Low
User Story: As a user, I want the router to run efficiently in terms of memory and time.
Acceptance Criteria: Change willScanNewCells() as described and compare the run time on the 100x100 grid unit test. If there is a >3% improvement on the unit test's reported run time after the change, keep the change and merge to development.

@Heckart Heckart added the enhancement New feature or request label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant