Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nondeterminism in lazify-measure #766

Merged
merged 9 commits into from
Feb 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tket2-hseries/src/lazify_measure.rs
Original file line number Diff line number Diff line change
@@ -125,7 +125,10 @@ impl LazifyMeasureRewrite {
Self::check_signature(node, QSystemOp::LazyMeasure, hugr.get_optype(node))?;

let subgraph = SiblingSubgraph::from_node(node, &hugr);
let uses = hugr.linked_inputs(node, 0).collect_vec();
// SimpleReplacement adds edges in a nondeterministic order. This
// results in linked_inputs returning items in a nondeterministic
// order. We sort them here to restore determinism.
let uses = hugr.linked_inputs(node, 0).sorted().collect_vec();
let (lazy_measure_node, replacement) = {
let bool_uses = uses.len();
let mut builder =
@@ -165,7 +168,8 @@ impl LazifyMeasureRewrite {
Self::check_signature(node, QSystemOp::LazyMeasureReset, hugr.get_optype(node))?;

let subgraph = SiblingSubgraph::from_node(node, &hugr);
let uses = hugr.linked_inputs(node, 1).collect_vec();
// See comment in try_new_measure
let uses = hugr.linked_inputs(node, 1).sorted().collect_vec();
let (lazy_measure_reset_node, replacement) = {
let bool_uses = uses.len();
let mut builder = {