feat: MakeTuple->UnpackTuple elision pass #2012
Open
+435
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
ab/sibling-subgraph-from-node
branch
from
b3dc6a5 to
bad40dc
Compare
mark-koch
reviewed
Mar 20, 2025
There was a problem hiding this comment.
Thanks! Mostly wondering about edge cases with order and inter-graph edges?
Btw, it would be nice to have the opposite UnpackTuple -> MakeTuple elison as well since Guppy sometimes emits those when dealing with structs. Happy for this to be a follow-up though
| let mut nodes = unpack_nodes; | ||
| nodes.push(pack_node); | ||
| let subcirc = SiblingSubgraph::try_from_nodes_with_checker(nodes, hugr, checker).unwrap(); | ||
| let subcirc_signature = subcirc.signature(hugr); |
There was a problem hiding this comment.
afaik this will panic if there are order edges?
|
|
||
| let mut nodes = unpack_nodes; | ||
| nodes.push(pack_node); | ||
| let subcirc = SiblingSubgraph::try_from_nodes_with_checker(nodes, hugr, checker).unwrap(); |
There was a problem hiding this comment.
What happens if the make-unpack is an inter-graph edge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports the
MakeTuple -> UnpackTupleelimination pass from tket2.This removes tuple unpacks consuming the output of a
MakeTuple, and deletes the packing operation when possible.This pass does not remove the reverse case,
Unpack->MakeTuple. Should it be added here? We should avoid producing overlapping rewrites if doing that (the simplePack->Unpack->Packcase is easy, but multiports can make things interesting).Requires #2011
Closes #1810