Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloca access #1957

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

alloca access #1957

wants to merge 4 commits into from

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Mar 7, 2025

No description provided.

@hugrbot
Copy link
Collaborator

hugrbot commented Mar 7, 2025

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Your title should look like this. The scope field is optional.

<type>(<scope>): <description>

If the PR includes a breaking change, mark it with an exclamation mark:

<type>!: <description>

and include a "BREAKING CHANGE:" footer in the body of the pull request.

Details:

No release type found in pull request title "alloca access". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - ci
 - chore
 - revert

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 61.36364% with 51 lines in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (4e6b6d8) to head (6430e92).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-llvm/src/extension/collections/array.rs 64.00% 3 Missing and 15 partials ⚠️
hugr-llvm/src/emit/func/mailbox.rs 0.00% 9 Missing ⚠️
hugr-llvm/src/emit/args.rs 65.21% 7 Missing and 1 partial ⚠️
hugr-llvm/src/emit/ops.rs 66.66% 0 Missing and 8 partials ⚠️
hugr-llvm/src/emit.rs 0.00% 0 Missing and 4 partials ⚠️
hugr-llvm/src/emit/ops/cfg.rs 80.95% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   83.77%   83.74%   -0.04%     
==========================================
  Files         199      199              
  Lines       38154    38075      -79     
  Branches    34967    34888      -79     
==========================================
- Hits        31963    31885      -78     
- Misses       4374     4391      +17     
+ Partials     1817     1799      -18     
Flag Coverage Δ
python 92.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Mar 7, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

--- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field ---

Description:
A struct constructible with a struct literal has a new non-public field. It can no longer be constructed using a struct literal outside of its crate.
      ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/constructible_struct_adds_private_field.ron

Failed in:
field EmitOpArgs.input_mailbox in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-llvm/src/emit/args.rs:22
field EmitOpArgs.input_mailbox in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-llvm/src/emit/args.rs:22

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/function_parameter_count_changed.ron

Failed in:
hugr_llvm::extension::collections::array::emit_array_op now takes 4 parameters instead of 5, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-llvm/src/extension/collections/array.rs:283

--- failure trait_method_parameter_count_changed: pub trait method parameter count changed ---

Description:
A trait method now takes a different number of parameters.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/trait_method_parameter_count_changed.ron

Failed in:
ArrayCodegen::emit_array_op now takes 4 instead of 5 parameters, in file /home/runner/work/hugr/hugr/PR_BRANCH/hugr-llvm/src/extension/collections/array.rs:65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants