Basic RBAC using the gauth library #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your Sigrid objective of 3.8 stars Show detailsSigrid compared your code against the baseline of 2024-12-09. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
MaartendeKruijf
requested changes
Nov 6, 2024
internal/controller/controller.go
Outdated
Comment on lines
186
to
201
| err := mainController.setupDatabase() | ||
| err = mainController.setupDatabase() | ||
| if err != nil { | ||
| log.Error(err) | ||
| log.Error("Failed to setup database:", err) |
There was a problem hiding this comment.
Why did this change?
internal/controller/controller.go
Outdated
Comment on lines
185
to
204
| authEnabledStr := utils.GetEnv("AUTH_ENABLED", "false") | ||
| authEnabled, err := strconv.ParseBool(authEnabledStr) | ||
| if err != nil { | ||
| log.Error(err) | ||
| return err | ||
| } | ||
|
|
||
| var auth *gauth.Authenticator | ||
| if authEnabled { | ||
| auth, err = gauth.New(gauth.DefaultConfig()) | ||
| if err != nil { | ||
| log.Error("Failed to initialize authenticator:", err) | ||
| return err | ||
| } | ||
| routes.Middlewares(app, auth.LoadAuthContext(), auth.Middleware([]string{"admin", "soarca"})) | ||
| } |
There was a problem hiding this comment.
This must be in it's own function
RabbITCybErSeC
force-pushed
the
feature/107-rbac-gauth
branch
2 times, most recently
from
113b84d to
cdfbb25
Compare
MaartendeKruijf
requested changes
Dec 7, 2024
.env.example
Outdated
|
|
||
| AUTH_ENABLED: false #OPTIONAL for OIDC Based auth |
There was a problem hiding this comment.
Comment is irrelevant
internal/controller/controller.go
Outdated
Comment on lines
190
to
201
|
|
||
| authEnabledStr := utils.GetEnv("AUTH_ENABLED", "false") | ||
| authEnabled, err := strconv.ParseBool(authEnabledStr) | ||
| if err != nil { | ||
| log.Error(err) | ||
| return err | ||
| } | ||
| routes.Cors(app, origins) | ||
|
|
||
| err := mainController.setupDatabase() | ||
| var auth *gauth.Authenticator | ||
| if authEnabled { | ||
| auth, err = gauth.New(gauth.DefaultConfig()) | ||
| if err != nil { | ||
| log.Error("Failed to initialize authenticator:", err) | ||
| return err | ||
| } | ||
| app.Use(auth.LoadAuthContext()) | ||
| app.Use(auth.Middleware([]string{"admin"})) | ||
| } | ||
|
|
||
| err = mainController.setupDatabase() | ||
| if err != nil { | ||
| log.Error(err) | ||
| log.Error("Failed to setup database:", err) |
There was a problem hiding this comment.
This is not core initialisation it can be moved into a different function
This reverts commit 4f0da89.
RabbITCybErSeC
force-pushed
the
feature/107-rbac-gauth
branch
from
b0143cb to
1eb56a4
Compare
MaartendeKruijf
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107