Bugfix/276 segmentation fault for ssh playbook (#277)

pkg/core/capability/ssh/ssh.go

@@ -55,10 +55,10 @@ func execute(command cacao.Command,
 		return cacao.NewVariables(), err
 	}
 	session, client, err := getSession(config, target)
-	defer client.Close()
 	if err != nil {
 		return cacao.NewVariables(), err
 	}
+	defer client.Close()
 
 	return executeCommand(session, command)
 }
@@ -67,12 +67,12 @@ func executeCommand(session *ssh.Session,
 	command cacao.Command) (cacao.Variables, error) {
 
 	response, err := session.Output(StripSshPrepend(command.Command))
-	defer session.Close()
 
 	if err != nil {
 		log.Error(err)
 		return cacao.NewVariables(), err
 	}
+	defer session.Close()
 	results := cacao.NewVariables(cacao.Variable{Type: cacao.VariableTypeString,
 		Name:  sshResultVariableName,
 		Value: string(response)})

test/integration/capability/ssh/ssh_integration_test.go

@@ -8,6 +8,7 @@ import (
 	"soarca/pkg/models/execution"
 	"testing"
 
+	"github.com/go-playground/assert/v2"
 	"github.com/google/uuid"
 )
 
@@ -58,3 +59,48 @@ func TestSshConnection(t *testing.T) {
 	fmt.Println(results)
 
 }
+
+func TestSshConnectionToNonExistingServer(t *testing.T) {
+	sshCapability := new(ssh.SshCapability)
+
+	expectedCommand := cacao.Command{
+		Type:    "ssh",
+		Command: "ls -la",
+	}
+
+	expectedAuthenticationInformation := cacao.AuthenticationInformation{
+		ID:       "some-authid-1",
+		Type:     "user-auth",
+		Username: "sshtest",
+		Password: "pdKY77qNxpI5MAizirtjCVOcm0KFKIs"}
+
+	expectedTarget := cacao.AgentTarget{
+		Type:    "ssh",
+		Address: map[cacao.NetAddressType][]string{"ipv4": {"10.10.10.10"}},
+		// Port:               "22",
+		AuthInfoIdentifier: "some-authid-1",
+	}
+
+	expectedVariables := cacao.Variable{
+		Type:  "string",
+		Name:  "var1",
+		Value: "testing",
+	}
+
+	var executionId, _ = uuid.Parse("6ba7b810-9dad-11d1-80b4-00c04fd430c8")
+	var playbookId = "playbook--d09351a2-a075-40c8-8054-0b7c423db83f"
+	var stepId = "step--81eff59f-d084-4324-9e0a-59e353dbd28f"
+	var metadata = execution.Metadata{ExecutionId: executionId, PlaybookId: playbookId, StepId: stepId}
+	data := capability.Context{
+		Command:        expectedCommand,
+		Target:         expectedTarget,
+		Authentication: expectedAuthenticationInformation,
+		Variables:      cacao.NewVariables(expectedVariables),
+	}
+	results, err := sshCapability.Execute(metadata,
+		data)
+	assert.NotEqual(t, err, nil)
+
+	fmt.Println(results)
+
+}