Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a flag wd_mass_lim #616

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Conversation

claireshiye
Copy link
Contributor

@claireshiye claireshiye commented Feb 12, 2024

Added a flag wd_mass_lim controlling if massive remnants (>Mch) from MIC are allowed.

Fixed a bug in evolv2.f where in elseif(kstar(j1).eq.10.or.kstar(j2).gt.10)then the or should be and.

The effects of the flag are partially demonstrated in this paper https://ui.adsabs.harvard.edu/abs/2024ApJ...961...98Y/abstract.

@katiebreivik
Copy link
Collaborator

👍

@katiebreivik katiebreivik merged commit ce46547 into COSMIC-PopSynth:develop Mar 7, 2024
4 checks passed
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 96.88716% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.72%. Comparing base (8772c07) to head (30d958f).
Report is 28 commits behind head on develop.

Files Patch % Lines
cosmic/src/evolv2.f 0.00% 5 Missing ⚠️
cosmic/evolve.py 0.00% 1 Missing ⚠️
cosmic/src/hrdiag_remnant.f 66.67% 1 Missing ⚠️
cosmic/utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #616      +/-   ##
===========================================
+ Coverage    86.91%   87.72%   +0.81%     
===========================================
  Files           40       42       +2     
  Lines        25542    25999     +457     
===========================================
+ Hits         22198    22806     +608     
+ Misses        3344     3193     -151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants