You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
right now the get_velocities throws some integration warnings when sampling from an Elson profile, largely because when numerically integrating the distribution function, you get a lot of roundoff error when the energy goes to zero. this is fine, especially for a generic Elson profile, but the Plummer profile (which is Elson when gamma=4) has an analytic distribution function that can be sampled directly, and would be a lot faster and not throw errors (which don't effect the results, but looks sloppy).
Carl, put in a special case function to draw from that distribution function when gamma=4
The text was updated successfully, but these errors were encountered:
So somehow this code never made it in? And the PR that supposedly fixed this is empty. Not sure what happened, but I'm going to have to code this up again and do another PR.
right now the get_velocities throws some integration warnings when sampling from an Elson profile, largely because when numerically integrating the distribution function, you get a lot of roundoff error when the energy goes to zero. this is fine, especially for a generic Elson profile, but the Plummer profile (which is Elson when gamma=4) has an analytic distribution function that can be sampled directly, and would be a lot faster and not throw errors (which don't effect the results, but looks sloppy).
Carl, put in a special case function to draw from that distribution function when gamma=4
The text was updated successfully, but these errors were encountered: