Skip to content

Commit

Permalink
Merge pull request #87 from COBREXA/mk-fix-strings
Browse files Browse the repository at this point in the history 
fix regression with string capacity names
  • Loading branch information
@exaexa
exaexa authored Jan 16, 2025
2 parents eefa8d3 + 36a1473 commit ebdb562
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "COBREXA"
uuid = "babc4406-5200-4a30-9033-bf5ae714c842"
authors = ["The developers of COBREXA.jl"]
version = "2.6.0"
version = "2.6.1"

[deps]
AbstractFBCModels = "5a4f3dfa-1789-40f8-8221-69268c29937c"
Expand Down
5 changes: 3 additions & 2 deletions src/frontend/enzymes.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,9 @@ $(TYPEDSIGNATURES)
Internal helper for implementation of [`expand_enzyme_capacity`](@ref) over
iterable `Dict`-like objects.
"""
expand_enzyme_capacity_iterable(x) =
return [id => (grp, expand_enzyme_capacity_bound(cap)) for (id, (grp, cap)) in x]
expand_enzyme_capacity_iterable(x) = return [
Symbol(id) => (grp, expand_enzyme_capacity_bound(cap)) for (id, (grp, cap)) in x
]

"""
$(TYPEDSIGNATURES)
Expand Down
3 changes: 3 additions & 0 deletions test/misc.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,7 @@ end
@test i == :test
@test ks == [:ident]
@test v == (0, 123)

x = expand_enzyme_capacity([("test", [], 0)], [])
@test first(x[1]) == :test
end

2 comments on commit ebdb562

@exaexa
Copy link
Member Author

@exaexa exaexa commented on ebdb562 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/123101

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.6.1 -m "<description of version>" ebdb562cf865b3835ebf8f9d98e0e8c7cd1c7f15
git push origin v2.6.1

Please sign in to comment.