Add tests to authenticator #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change npm package lock file by yarn one. Also install these libraries: - prettier: code formatter - husky: pre commit and pre push hook - lint-stage: allow husky hook to be executed only in staged files - jest: test framework
In order to mock HTTP class in authenticator tests, this patch change the authenticator constructor, passing the HTTP itself instead of it's settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR introduces: This patch implements unit tests for authenticator interface
What kind of change does this PR introduce? (check at least one)
Does this PR introduce any breaking changes? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)Testing environment:
If you have relevant logs, error output and etc, please attach them.
Other information: