Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KNoT Type IDs acceleration and angular velocity #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add KNoT Type IDs acceleration and angular velocity #15

wants to merge 2 commits into from

Conversation

luigiluz
Copy link

What does this implement/fix? Explain your changes.

This adds support to the two new KNoT Type IDs, that is:

  • Acceleration (using int as its KNoT Type Value);
  • Angular velocity (using float as its KNoT Type Value).

@luigiluz luigiluz requested review from netoax and ramonhpr January 17, 2020 12:06
@luigiluz luigiluz self-assigned this Jan 17, 2020
netoax
netoax suggested changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@netoax netoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luigiluz your patch looks good to me, but I think you can add detailed descriptions to the commits explaining why these new types are being added.

@netoax netoax added enhancement New feature or request priority: medium labels Jan 20, 2020
@luigiluz luigiluz force-pushed the knot-type-ids-accel-angvel branch from a4abae8 to 8c05eca Compare January 21, 2020 14:48
@netoax netoax self-requested a review January 22, 2020 13:26
netoax
netoax approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@netoax netoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for protocol request changes to be approved.

@luigiluz
Add KNoT Type ID acceleration
e562cf4 
This new type ID is being added to be used in applications that requires
acceleration measurements. Ex: Using an accelerometer.
@luigiluz
Add KNoT Type ID angular velocity
946ddf2 
This new type ID is being added to be used in applications that requires
angular velocity measurements. Ex: Using a gyroscope.
@luigiluz luigiluz force-pushed the knot-type-ids-accel-angvel branch from 8c05eca to 946ddf2 Compare January 23, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netoax netoax netoax approved these changes

@ramonhpr ramonhpr Awaiting requested review from ramonhpr

Assignees

@luigiluz luigiluz

Labels
enhancement New feature or request priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luigiluz @netoax