Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions #73

Merged
merged 2 commits into from
May 7, 2020
Merged

Add github actions #73

merged 2 commits into from
May 7, 2020

Conversation

ramonhpr
Copy link
Contributor

@ramonhpr ramonhpr commented May 7, 2020

Describe what this PR introduces: (if necessary, link currently open issues with special keywords)

Add github action to build and run tests. Also make the key word PASS and FAILED
colored 😄
Related to #26

What kind of change does this PR introduce? (check at least one)

  • Bug fix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
    Add github actions to build and tests for every commit that enter on master and for every pull request opened.

Does this PR introduce any breaking changes? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • Related issues are referenced in the PR (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

Testing environment:

  • Operating System/Platform: 5.4.35-1-MANJARO
  • Go version: 1.14.2

If you have relevant logs, error output and etc, please attach them.

Other information:

@ramonhpr ramonhpr requested a review from netoax May 7, 2020 11:10
@ramonhpr ramonhpr requested review from lcbm and vitbaq as code owners May 7, 2020 11:10
@ramonhpr ramonhpr self-assigned this May 7, 2020
@ramonhpr ramonhpr changed the title Devel actions Add github actions May 7, 2020
Copy link
Contributor

@netoax netoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the contribution. I did just two comments to help you improve it. 🎉

branches: [ master ]

jobs:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok removing this blank line to follow the same pattern of on: push: ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok. I gonna test it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- name: Set up Go 1.x
uses: actions/setup-go@v2
with:
go-version: ^1.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be 1.14?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

branches: [ master ]

jobs:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok. I gonna test it

- name: Set up Go 1.x
uses: actions/setup-go@v2
with:
go-version: ^1.13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

README.md Outdated Show resolved Hide resolved
@ramonhpr ramonhpr force-pushed the devel_actions branch 2 times, most recently from a627197 to 5a07538 Compare May 7, 2020 20:44
Copy link
Contributor

@netoax netoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@lcbm lcbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks @ramonhpr 😍

@ramonhpr ramonhpr merged commit 23fb967 into CESARBR:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants