Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event device.registered with token is broadcast to all client listen #80

Open
ramonhpr opened this issue Jun 2, 2020 · 0 comments
Open

Event device.registered with token is broadcast to all client listen #80

ramonhpr opened this issue Jun 2, 2020 · 0 comments
Labels
bug Something isn't working priority: high

Comments

@ramonhpr
Copy link
Contributor

ramonhpr commented Jun 2, 2020

This bug is a security issue due the token being broadcast to all client listen to event device.registered.

Proposed solution:

  • Make the register use the Rabbit RPC (using correlation_id and replyTo) so the event will be transmited just to the client queuename that made the request for the register.

IMO, the operations register, unregister and schema should use RPC because it avoid the client keep looking to ID property receving an event that wasn't requested by it.
@ramonhpr ramonhpr added bug Something isn't working priority: high labels Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramonhpr