Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The PHONE NUMBER field has no validate on REGISTER and EDIT screen #45

Open
maioni opened this issue Apr 3, 2020 · 3 comments
Open
Labels
bug Something isn't working

Comments

@maioni
Copy link
Collaborator

maioni commented Apr 3, 2020

Describe the bug
[BUG] The PHONE NUMBER field has no validate on REGISTER and EDIT screen

To Reproduce (First Scenario)
Steps to reproduce the behavior:

  1. Already login
  2. Register a new contact with a not valid phone number (123, 000, ...)
  3. Go to the contact detail and save it again with an another wrong phone number (999, 03, ...)

Actual behavior
2/3. Wrong phone number is registered or edited with success

Expected behavior
2/3. Wrong phone number can't be registered or edited, it fails

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
N/A

@vcasadei
Copy link
Contributor

vcasadei commented Apr 3, 2020

What do you consider being a wrong or invalid Phone number? I ask this because we need to create a rule for this validation, and I do not know a perfect one.

@maioni
Copy link
Collaborator Author

maioni commented Apr 3, 2020

city code with 2 digits + first number 9 + follow by 8 digits [Brazil]:
15912345678
https://numverify.com/ > API JSON
I know that exist solutions also to verify if its a landline phone or a cell phone, this field should not accept landline phones
https://www.phonevalidator.com/

@maioni
Copy link
Collaborator Author

maioni commented Apr 29, 2020

Issue remains reproducible:
image

@maioni maioni added the bug Something isn't working label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants