Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor injection #162

Merged
merged 14 commits into from
Feb 14, 2025
Merged

Constructor injection #162

merged 14 commits into from
Feb 14, 2025

Conversation

John-Wiens
Copy link
Collaborator

PR Details

Description

This PR cleans up the intersection API by switching spring to use constructor injection. This will help to prevent null pointer errors when dependencies are not available in the future.

How Has This Been Tested?

Unit tests were run to make sure all components are still functioning. A selection of REST endpoints were verified manually by running the CV-Manager GUI.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@John-Wiens John-Wiens requested a review from jacob6838 February 13, 2025 21:56
Copy link
Collaborator

@jacob6838 jacob6838 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intersection api builds, test pass, and webapp can retrieve data

@jacob6838 jacob6838 merged commit af46c93 into develop Feb 14, 2025
8 checks passed
@jacob6838 jacob6838 deleted the constructor-injection branch February 14, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants