-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Message Samples + MultiPoint #56
Conversation
jacob6838
commented
Nov 8, 2024
- Updating message samples for planned events and icone datasets
- Using geometry type "MultiPoint" for events without enhanced geometry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have two "production_sample.json" files, one under /enhanced and one under /enhanced/planned_events. They appear to be identical, do we need both?
What are the files under |
Those are an example a planned event being modified by the experimental_combination/icone script. The diff file shows exactly what was modified by the combination script, and the others are raw values for each input/output. I can add a README here to describe it |
Ah, yeah let's get a README in there, this is definitely useful addition |
Just pushed this new README! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Tests pass and comments have been addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me!