Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Message Samples + MultiPoint #56

Merged
merged 20 commits into from
Dec 9, 2024
Merged

Conversation

jacob6838
Copy link
Collaborator

  • Updating message samples for planned events and icone datasets
  • Using geometry type "MultiPoint" for events without enhanced geometry

Copy link
Contributor

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have two "production_sample.json" files, one under /enhanced and one under /enhanced/planned_events. They appear to be identical, do we need both?

@payneBrandon
Copy link
Contributor

What are the files under experimental/prod_experimental_diff_20230522-140004/ used for?

@jacob6838
Copy link
Collaborator Author

What are the files under experimental/prod_experimental_diff_20230522-140004/ used for?

Those are an example a planned event being modified by the experimental_combination/icone script. The diff file shows exactly what was modified by the combination script, and the others are raw values for each input/output. I can add a README here to describe it

@payneBrandon
Copy link
Contributor

What are the files under experimental/prod_experimental_diff_20230522-140004/ used for?

Those are an example a planned event being modified by the experimental_combination/icone script. The diff file shows exactly what was modified by the combination script, and the others are raw values for each input/output. I can add a README here to describe it

Ah, yeah let's get a README in there, this is definitely useful addition

@jacob6838
Copy link
Collaborator Author

What are the files under experimental/prod_experimental_diff_20230522-140004/ used for?

Those are an example a planned event being modified by the experimental_combination/icone script. The diff file shows exactly what was modified by the combination script, and the others are raw values for each input/output. I can add a README here to describe it

Ah, yeah let's get a README in there, this is definitely useful addition

Just pushed this new README!

@payneBrandon payneBrandon requested a review from mwodahl November 21, 2024 17:47
Copy link
Contributor

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions

Copy link
Contributor

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tests pass and comments have been addressed

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@payneBrandon payneBrandon merged commit 76326bb into main Dec 9, 2024
2 checks passed
@payneBrandon payneBrandon deleted the updating-samples branch December 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants