Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TypeError in Pci Requests #60

Merged
merged 1 commit into from
May 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/openstack_billing_db/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@
import datetime
from dataclasses import dataclass
from dataclasses_json import dataclass_json
import logging
import sqlite3
from typing import Optional

logger = logging.getLogger(__name__)


@dataclass_json()
@dataclass()
Expand Down Expand Up @@ -230,7 +233,13 @@ def get_instances(self, project) -> list[Instance]:
)

for instance in cursor.fetchall():
pci_info = json.loads(instance["pci_requests"])
try:
pci_info = json.loads(instance["pci_requests"])
except TypeError:
pci_info = None
logger.warning(
f"Could not parse pci requests from instance {instance}."
)
su_name = "cpu"
if pci_info:
# The PCI Requests column of the database contains a JSON
Expand Down
Loading