Fixed the OTP functionality #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the OTP verification flow to enhance the user experience and prepare for future features. It refines the VerificationCubit for better state management, adds meaningful error handling with informative messages in the failure state, and introduces clearer state transitions. A significant performance improvement is achieved by implementing const constructors for state classes, enabling compile-time constant creation and reducing memory allocation. These changes not only bring the application closer to industry standards but also lay the groundwork for implementing features like OTP resending and password reset in upcoming iterations, while improving maintainability and responsiveness. Unit tests have been added to verify the correctness of the changes, and the application has been tested on physical devices and emulators.