Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-1344 #152

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

CRDCDH-1344 #152

wants to merge 15 commits into from
+452 −377

Conversation

kuffelgr
Copy link
Contributor

ICDC data model updates requested by the CRDC Data Hub team.

There are many updates included in this PR, notably:

  1. The attempt to ascribe an appropriate unique identifier across every node in the model. In some cases this resulted in the promotion of an existing property to a "key" property. In other cases a new property was created, with the format node_name_id.
  2. Proposed removal or deprecation of nodes and properties that do not have any data values across all ingested ICDC studies.

@kuffelgr kuffelgr changed the base branch from master to develop July 22, 2024 21:17
@kuffelgr
Update icdc-model-props.yml
d7b38c7 
added missing fields for pi_id
@kuffelgr kuffelgr requested review from PhilipMusk and majensen July 22, 2024 21:24
majensen
majensen reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@majensen majensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuffelgr I'm going to hold forth on this uniqueness problem in an email today. I just think this process is headed for a complete hairball, when data hub should actually do this lifting. Stand by.

majensen
majensen approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@majensen majensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved to unblock the Data Hub process. I have severe misgivings that will be sorted out later.

@kuffelgr kuffelgr requested a review from n2iw July 29, 2024 17:23
n2iw
n2iw approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@n2iw n2iw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amattu2 amattu2 mentioned this pull request Aug 20, 2024
Merged
n2iw
n2iw approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@n2iw n2iw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majensen majensen majensen approved these changes

@n2iw n2iw n2iw approved these changes

@PhilipMusk PhilipMusk Awaiting requested review from PhilipMusk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuffelgr @majensen @n2iw