Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt GW code to use the same soil properties as the main branch. #541

Open
ccarouge opened this issue Feb 10, 2025 · 0 comments
Open

Adapt GW code to use the same soil properties as the main branch. #541

ccarouge opened this issue Feb 10, 2025 · 0 comments
Labels
GWH Ground water hydrology integration work

Comments

@ccarouge
Copy link
Member

In the GW work, two soil properties have incompatible changes with the main part of the code:

  • soil%hyds_vec is in mm/s while soil%hyds is in m/s.
  • soil%sucs_vec is of the opposite sign compared to soil%sucs.

This means the ranges for each parameter and variable defined in ranges_type will not be compatible with the GW parameters. It also introduces sign changes and unit conversions at various places in the initialisation routines.

The preferred solution is to change the GW code to use the same units and sign convention as the main code. This should also be accompanied with a corresponding change in the GW input files.

@ccarouge ccarouge added the GWH Ground water hydrology integration work label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GWH Ground water hydrology integration work
Projects
None yet
Development

No branches or pull requests

1 participant