You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 21, 2022. It is now read-only.
Currently the MASRequest builder only accepts an NSDictionary as the request body. This is an issue as not all (of our) endpoints expect a dictionary as the root object of a request's body.
Some possible fixes could be to:
use id as the body's type (this change does not existing impact users when they update).
use NSData as the body's type (breaking change and users have to encode the json themselves. Offers flexibility however).
Introduce a JSONObject class as the body's type (JSONObject would then be initializable with all valid json data types: NSNumber, NSString, Bool, NSDictionary, NSArray, etc. This limits the amount of "valid" types a user could use to set the request body):
PR: #291
Currently the MASRequest builder only accepts an
NSDictionary
as the request body. This is an issue as not all (of our) endpoints expect a dictionary as the root object of a request's body.Some possible fixes could be to:
id
as the body's type (this change does not existing impact users when they update).NSData
as the body's type (breaking change and users have to encode the json themselves. Offers flexibility however).JSONObject
class as the body's type (JSONObject would then be initializable with all valid json data types:NSNumber
,NSString
,Bool
,NSDictionary
,NSArray
, etc. This limits the amount of "valid" types a user could use to set the request body):The text was updated successfully, but these errors were encountered: