Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version.entities path in index.docbook #145

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Feb 6, 2024

Since Makefile is running xmllint with --path C and the version.entities file is inside C's parent directory, its location needs to be adjusted to ../version.entities.

Fixes #144

@ensonic
Copy link
Member

ensonic commented Feb 7, 2024

I guess this works, as we have the version.entities in both places?

An alternative could be to change the current working dir in https://github.com/Buzztrax/buzztrax/blob/master/tests/xmlvalid.sh#L61

Let me think for a bit.

@ensonic ensonic merged commit 0716f41 into Buzztrax:master Feb 7, 2024
1 check failed
@ensonic
Copy link
Member

ensonic commented Feb 7, 2024

Tested both in and out of srcdir builds. Looks good. Thanks!

@rffontenelle rffontenelle deleted the patch-1 branch February 7, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xmllint reports variables not being set
2 participants