Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNA_construct equality compares __repr__ instead of object instance #237

Open
dr3y opened this issue May 14, 2021 · 0 comments
Open

DNA_construct equality compares __repr__ instead of object instance #237

dr3y opened this issue May 14, 2021 · 0 comments

Comments

@dr3y
Copy link
Collaborator

dr3y commented May 14, 2021

DNA_construct is a Component but it has a different way of evaluating equality than a Component.

I did this because I don't want constructs with different data members (constructs that have or haven't been combinatorially enumerated) to be considered different (since they are, basically, the same construct and should yield the same combinatorial enumeration at the end).

However, it would be good if the equality method of all components was the same, so the suggested change is to change the equality function to something else and then use that everywhere where I am currently using equality.

I think this would involve a pretty significant number of changes to integrase_enumerator and DNA_construct and related things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant