Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concentration to number of molecules converter #2

Open
blakeaw opened this issue Jun 20, 2024 · 1 comment
Open

Concentration to number of molecules converter #2

blakeaw opened this issue Jun 20, 2024 · 1 comment

Comments

@blakeaw
Copy link
Contributor

blakeaw commented Jun 20, 2024

Suggested by James Pino:

Something like a units.Model.to_molecules(vol=...) converter that can take a model in concentration units and quickly yield its molecular counts. This would be useful for stochastic simulations.

@blakeaw blakeaw mentioned this issue Jun 24, 2024
@blakeaw
Copy link
Contributor Author

blakeaw commented Jun 25, 2024

This is partially addressed by PR #4, which adds the new SimulationUnits class and the set_molecule_volume function that can be used to enforce automatic conversion of parameters with molar concentrations to molecular counts as part of the model definition.

However, the functionality of something like a Model.to_molecules function has yet to be fully implemented. This is a bit more difficult since the units for expressions that include a concentration must be reconstructed after applying the appropriate conversion to parameters and observables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant