support Xiaomi Occupancy(Human Presence) Sensor XMOSB01XS #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support 2024 New battery based Xiaomi Mijia Occupancy (Human Presence) Sensor (XMOSB01XS) New test cases are added. Also verified by adding it to Home Assistant (with a small additional changes in xiaomi-ble component for additional new properties) Hardware Info: https://www.aliexpress.com/i/1005007104780534.html https://www.mi.com/shop/buy/detail?product_id=19994
Ernst79
reviewed
Aug 27, 2024
| def obj484e( | ||
| xobj: bytes, device: XiaomiBluetoothDeviceData, device_type: str | ||
| ) -> dict[str, Any]: | ||
| """Occupancy-status: uint8: 0 - No One, 1 - Has One""" |
There was a problem hiding this comment.
Suggested change
| """Occupancy-status: uint8: 0 - No One, 1 - Has One""" | |
| """Occupancy-status: uint8: 0 - Clear, 1 - Detected""" |
Ernst79
reviewed
Aug 27, 2024
| @@ -80,3 +80,9 @@ class ExtendedSensorDeviceClass(BaseDeviceClass): | |||
|
|
|||
| # Toothbrush score | |||
| SCORE = "score" | |||
|
|
|||
| # Has-Someone-Duration | |||
| HAS_SOMEONE_DURATION = "has_someone_duration" | |||
There was a problem hiding this comment.
I would use something like
duration someone detected and duration clear
Ernst79
requested changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support 2024 New battery based Xiaomi Mijia Occupancy (Human Presence) Sensor (XMOSB01XS)
New test cases are added.
Also verified by adding it to Home Assistant (with a small additional changes in xiaomi-ble component for additional new properties)
Hardware Info: