Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add a nexus access point converter and improve CLI #14

Merged
merged 39 commits into from
Nov 30, 2023

Conversation

arnaudon
Copy link
Collaborator

No description provided.

@arnaudon arnaudon self-assigned this Oct 18, 2023
@arnaudon arnaudon marked this pull request as draft October 18, 2023 15:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #14 (5a7205c) into main (682b7d0) will decrease coverage by 9.22%.
The diff coverage is 27.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   38.48%   29.27%   -9.22%     
==========================================
  Files          21       22       +1     
  Lines        5560     5697     +137     
  Branches     1048     1086      +38     
==========================================
- Hits         2140     1668     -472     
- Misses       3164     3839     +675     
+ Partials      256      190      -66     
Flag Coverage Δ
pytest 29.27% <27.16%> (-9.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
emodel_generalisation/model/access_point.py 53.10% <36.36%> (-1.22%) ⬇️
emodel_generalisation/cli.py 76.27% <43.85%> (-6.44%) ⬇️
emodel_generalisation/model/nexus_converter.py 13.25% <13.25%> (ø)

... and 11 files with indirect coverage changes

@arnaudon arnaudon changed the title Feat: Add a nexus access point conveter Feat: Add a nexus access point converter and improve CLI Nov 8, 2023
@arnaudon
Copy link
Collaborator Author

waiting on BlueBrain/BlueCelluLab#109 to pass the tests

@arnaudon arnaudon marked this pull request as ready for review November 29, 2023 12:42
@arnaudon arnaudon merged commit 10a03d9 into main Nov 30, 2023
6 checks passed
@arnaudon arnaudon deleted the nexus_converter branch November 30, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants